ebpf.plugin: rework memory #19844
Merged
ebpf.plugin: rework memory #19844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
|
This pull request has been mentioned on Netdata Community Forums. There might be relevant details there: https://community.netdata.cloud/t/mem-cachestat-ratio-doesnt-work-after-upgrading-netdata/7345/3 |
thiagoftsm
force-pushed
the
ebpf_rework_mem
branch
2 times, most recently
from
a5a213e to
7884d46
Compare
thiagoftsm
force-pushed
the
ebpf_rework_mem
branch
from
3bb8cda to
8fc84b5
Compare
thiagoftsm
force-pushed
the
ebpf_rework_mem
branch
2 times, most recently
from
46b67a9 to
82fb8fc
Compare
…implifying this PR
… memory used to store data
…fix from previous commit
thiagoftsm
force-pushed
the
ebpf_rework_mem
branch
from
82fb8fc to
409fe31
Compare
|
I rebased the PR to verify no changes were introduced after the latest commits. This PR has been running successfully for four days without any issues. After completing one final test with the most recent commits, it will be marked as ready for review. |
ktsaou
approved these changes
Mar 28, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Mar 28, 2025
(cherry picked from commit 12e830a)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Apr 2, 2025
(cherry picked from commit 12e830a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the last PR before move integration from ebpf.plugin to apps.plugin and cgroup.plugin.
It address some SIGABRT and SIGSEGV identified with code allocation. On all scenarios where it was tested, I could not observe more the issues after the development finished.
Test Plan
Additional Information
This PR was tested on:
For users: How does this change affect me?
Describe the PR affects users: - Which area of Netdata is affected by the change? ebpf.plugin - Can they see the change or is it an under the hood? If they can see it, where? Plugin is going to need less memory. - How is the user impacted by the change? A more stable plugin. - What are there any benefits of the change? Plugin using less memory and without some ancient issues.