Skip to content

Add ADC class. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Add ADC class. #52

merged 1 commit into from
Sep 2, 2023

Conversation

yuuu
Copy link
Contributor

@yuuu yuuu commented Sep 2, 2023

I added a PWM class according to the "peripheral class common specifications".
https://github.com/HirohitoHigashi/mruby_io_class_study/blob/main/mruby_io_ADC.md

As you know, mruby-esp32-gpio already has analog_read. I think in the future we should separate the methods from that class. The new class allows you to specify ADC_UNIT_1 and has slightly better performance because you don't have to set the config all over again.

The added mruby-esp32-adc is the following URL. Please review it.
https://github.com/mruby-esp32/mruby-esp32-adc

@yuuu yuuu self-assigned this Sep 2, 2023
@yuuu yuuu requested review from vickash and pandax381 September 2, 2023 08:05
@yuuu yuuu merged commit 6fac2a4 into master Sep 2, 2023
@yuuu
Copy link
Contributor Author

yuuu commented Sep 2, 2023

@pandax381 Thank you for your approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants