Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a PWM class according to the "peripheral class common specifications".
https://github.com/HirohitoHigashi/mruby_io_class_study/blob/main/mruby_io_ADC.md
As you know, mruby-esp32-gpio already has analog_read. I think in the future we should separate the methods from that class. The new class allows you to specify ADC_UNIT_1 and has slightly better performance because you don't have to set the config all over again.
The added mruby-esp32-adc is the following URL. Please review it.
https://github.com/mruby-esp32/mruby-esp32-adc