Skip to content

Add the new esp_adc component for the updated GPIO gem #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2023
Merged

Add the new esp_adc component for the updated GPIO gem #44

merged 1 commit into from
Jul 17, 2023

Conversation

vickash
Copy link
Contributor

@vickash vickash commented Jul 16, 2023

Merge this PR only when this other PR has been merged, and merged into the 0.5 branch of that gem.

This repo uses that 0.5 branch as its source for the GPIO gem.

This PR adds the up-to-date esp_adc component to the IDF project, which the updated GPIO gem will need to work.

yuuu
yuuu approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@yuuu yuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and LGTM!!

@yuuu yuuu merged commit 975ff64 into master Jul 17, 2023
@yuuu yuuu deleted the gpio_gem_update branch July 17, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuuu yuuu yuuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vickash @yuuu