[auth]: revision of support oauth client_secret_basic / none / custom methods #723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #720, but makes a couple changes to
addClientAuthentication
, as follows:Function signature changed from:
addClientAuthentication?(url: URL, headers: Headers, params: URLSearchParams): void | Promise<void>;
to:
addClientAuthentication?(headers: Headers, params: URLSearchParams, url: string | URL, metadata?: OAuthMetadata): void | Promise<void>;
The most important change here has passing
metadata
, which allows the custom authentication method to fully negotiate based on authorization server capabilities. Theurl
argument was moved to the third argument for aesthetic reasons, keeping it next tometadata
.The
url
argument was also changed to accept theauthorizationServerUrl
, rather thantokenUrl
, so it could resolve any URLs present in metadata correctly.Motivation and Context
This allows
OAuthClientProvider
s to implement custom authentication methods, such asprivate_key_jwt
.How Has This Been Tested?
Unit tests. Custom
OAuthClientProvider
implementations implementing custom authentication methods.Breaking Changes
N/A
Types of changes
Checklist
Additional context