Compress MgCommandMetadata.json to reduce whitespace/package size for Microsoft.Graph.Authentication
#3346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th `-Compress` on `ConvertTo-Json`
…th `-Compress` on `ConvertTo-Json`
|
@ramsessanchez @timayabi2020 Can someone from your team take a look at this PR please? It's been two weeks. As it stands, we're unable to ship MSGraph into our Lambda functions because the size of the modules is over Lambda's maximum dependency size. |
|
@microsoftgraph/msgraph-powershell-team What's needed to move the needle on this PR? The changes here remove JSON space that parsers (like PowerShell's It's been over a month with no feedback on this PR or on #3345. I don't know what else I can do as an external contributor. |
sean-r-williams
changed the title
Microsoft.Graph.Authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3345.
Changes proposed in this pull request
Adds
-CompresstoConvertTo-Jsoncalls in post-generation tools:AuthModuleMetadataNewCommandMetadataThese tools appear to operate on
MgCommandMetadata.json, which has nearly 6MB of unnecessary whitespace. About 13.9% ofMicrosoft.Graph.Authentication's unpacked size on-disk is wasted by formatting characters that JSON parsers ignore anyways.Certainly welcome to feedback on this PR - these files don't appear to be getting auto-updated by CI, and I was looking for specifically the
MgCommandMetadata.jsonfilename. I'm not sure if there are other AutoREST directives/generator tools that need updating as well.