Skip to content

feat: update type definition #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

feat: update type definition #816

merged 1 commit into from
Oct 25, 2021

Conversation

AkatQuas
Copy link
Contributor

Update the type definition.

Since typescript@4.4.0 , the TS1336 is not problem any more.

So this issue is acceptable if the typescript version is bumped in the root package.json.

dbaeumer
dbaeumer reviewed Sep 16, 2021
View reviewed changes
Copy link
Member

@dbaeumer dbaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes require TS version 4.4.3 which not everybody might use. They produce a compile error when using < 4.4.x

capture

So I would like to hold off of them until this is more widely adopted.

@dbaeumer
Copy link
Member

We are now on 4.4.4.

@dbaeumer dbaeumer merged commit 063baef into microsoft:main Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaeumer dbaeumer dbaeumer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AkatQuas @dbaeumer