Skip to content

chore: test on python 3.10 #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 10, 2021
Merged

chore: test on python 3.10 #847

merged 4 commits into from
Sep 10, 2021

Conversation

kumaraditya303
Copy link
Contributor

Python 3.10rc is out and hence we should add it to CI to prevent breakage when the final is out.

@kumaraditya303 kumaraditya303 marked this pull request as draft August 14, 2021 08:17
@mxschmitt
Copy link
Member

mxschmitt commented Aug 16, 2021

let's wait until 3.10 is released. Also a few more changes are related:

  • add labels in setup.py
  • build the python 3.10 conda package
  • wait that a new version of the websocket package was released

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Aug 16, 2021

See https://discuss.python.org/t/python-3-10-0rc1-is-now-available/9982, no need to wait for final 3.10 release as libraries should support it from rc itself.

add labels in setup.py

Added

build the python 3.10 conda package

Can be done later as conda does not support 3.10 currently.

wait that a new version of the websocket package was released

A new version is only required if you are using it on 3.10 hence there is a python version marker
websockets @ https://github.com/aaugustin/websockets/archive/6edb363af07365867b4c372405b6ab3177a57830.tar.gz; python_version >= '3.10' , We are just testing here not using 3.10 and the marker will be removed after a new version is released.

This is how other libraries do it, see encode/uvicorn#1149

@kumaraditya303 kumaraditya303 marked this pull request as ready for review August 16, 2021 11:13
@mxschmitt mxschmitt merged commit 6cb70f3 into microsoft:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants