chore(protocol): implement client side hello #836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
reviewed
Aug 5, 2021
mxschmitt
force-pushed
the
new-protocol
branch
2 times, most recently
from
50e081e to
f48ec89
Compare
mxschmitt
force-pushed
the
new-protocol
branch
2 times, most recently
from
3a54b87 to
2de45fb
Compare
mxschmitt
force-pushed
the
new-protocol
branch
2 times, most recently
from
964b217 to
d5cdd0b
Compare
mxschmitt
force-pushed
the
new-protocol
branch
from
d5cdd0b to
ee8a594
Compare
|
I don't think we want all those callbacks. Now that the client is establishing the connection, can we have something simple like connection.connect() that returns the Playwright object? |
mxschmitt
force-pushed
the
new-protocol
branch
from
063586a to
91160ef
Compare
mxschmitt
force-pushed
the
new-protocol
branch
2 times, most recently
from
e618f77 to
25950ce
Compare
mxschmitt
force-pushed
the
new-protocol
branch
2 times, most recently
from
f66c5be to
02e5fb0
Compare
mxschmitt
force-pushed
the
new-protocol
branch
from
02e5fb0 to
435c587
Compare
pavelfeldman
approved these changes
Aug 26, 2021
mxschmitt
force-pushed
the
new-protocol
branch
from
867b047 to
435c587
Compare
mxschmitt
force-pushed
the
new-protocol
branch
from
d10e7db to
dccdab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.