Skip to content

chore: remove redundant code #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2021
Merged

chore: remove redundant code #759

merged 2 commits into from
Jun 23, 2021

Conversation

kumaraditya303
Copy link
Contributor

No description provided.

@pavelfeldman
Copy link
Member

Did you re-generate api after changing generators?

@kumaraditya303
Copy link
Contributor Author

There isn't any changes to the generator only removed a redundant line, I have regenerated and there wasn't any changes

@kumaraditya303
Copy link
Contributor Author

Moreover we have ci testing the generator and they are also passing

@mxschmitt
Copy link
Member

Please do not bump dev dependencies inside such a PR, leave PRs only related to the PR title and don't mix multiple unrelated changes in it.

@kumaraditya303
Copy link
Contributor Author

@mxschmitt Separated it to #764 and lets get that merged first

@pavelfeldman pavelfeldman merged commit 61b1a03 into microsoft:master Jun 23, 2021
@kumaraditya303 kumaraditya303 deleted the cleanup-generator branch June 24, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants