Skip to content

chore: added headers param for BrowserType.connect #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2021
Merged

chore: added headers param for BrowserType.connect #648

merged 2 commits into from
Apr 28, 2021

Conversation

kumaraditya303
Copy link
Contributor

No description provided.

mxschmitt
mxschmitt reviewed Apr 25, 2021
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason of changing that? Does it fix something?

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Apr 25, 2021 •
edited
Loading

Calling str and Path is redundant and in case could result in not resolve symlink as pathlib requires Path.resolve() for symlink resolving. Python has a dedicated function for it os.fspath which is more appropriate for it See docs https://docs.python.org/3/library/pathlib.html#pathlib.Path.resolve

@kumaraditya303 kumaraditya303 changed the title feat: Tracing chore: added headers param for BrowserType.connect Apr 27, 2021
@kumaraditya303 kumaraditya303 marked this pull request as ready for review April 27, 2021 10:19
mxschmitt
mxschmitt reviewed Apr 28, 2021
View reviewed changes
@mxschmitt mxschmitt merged commit 027c1fb into microsoft:master Apr 28, 2021
@kumaraditya303 kumaraditya303 deleted the feature/tracing branch May 4, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @mxschmitt