Skip to content

fix: remove stack from WaitForEventInfo #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2021
Merged

fix: remove stack from WaitForEventInfo #639

merged 1 commit into from
Apr 23, 2021

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Apr 22, 2021 •
edited
Loading

No description provided.

@kumaraditya303 kumaraditya303 mentioned this pull request Apr 22, 2021
Closed
@mxschmitt mxschmitt linked an issue Apr 22, 2021 that may be closed by this pull request
[internal] remove stack from WaitForEventInfo #637
Closed
pavelfeldman
pavelfeldman requested changes Apr 22, 2021
View reviewed changes
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need this stack, the one you want to remove is in _wait_for_event_info_before

@kumaraditya303 kumaraditya303 marked this pull request as ready for review April 23, 2021 11:59
@kumaraditya303
Copy link
Contributor Author

@pavelfeldman @mxschmitt Fixed now, can be merged now

@mxschmitt mxschmitt merged commit 050b889 into microsoft:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[internal] remove stack from WaitForEventInfo
3 participants
@kumaraditya303 @pavelfeldman @mxschmitt