Skip to content

test: migrate to expect_ where possible #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

test: migrate to expect_ where possible #428

merged 1 commit into from
Jan 15, 2021

Conversation

pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Jan 14, 2021 •
edited
Loading

Fixes #270

@pavelfeldman pavelfeldman changed the title test: mmigrate to expect_ where possible test: migrate to expect_ where possible Jan 14, 2021
@pavelfeldman pavelfeldman force-pushed the change_all_tests branch 2 times, most recently from 415570b to 6965d24 Compare January 14, 2021 22:27
dgozman
dgozman approved these changes Jan 14, 2021
View reviewed changes
@mxschmitt
Copy link
Member

great refactor, simplifies it a lot internally.

@pavelfeldman pavelfeldman merged commit 25a99d5 into microsoft:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expect_event creates task and hence races incoming event
3 participants
@pavelfeldman @mxschmitt @dgozman