chore: roll Playwright to 0.170.0-next.1608058598043 #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Dec 15, 2020
mxschmitt
approved these changes
Dec 15, 2020
| "**/*", | ||
| lambda route: asyncio.create_task(route.fulfill(body="<html></html>")), | ||
| ) | ||
| await page1.goto("https://www.example.com") |
There was a problem hiding this comment.
Can we use our local test webserver for that? Relying on other websites (even since its maintained by the IANA) isn't ideal.
There was a problem hiding this comment.
We are not relying on external website here, but we do rely upon the DNS / cache. I'd say it is ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.