fix(threads): fix the separate thread execution in 3.7, add tests #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
approved these changes
Dec 10, 2020
tests/sync/test_sync.py
Outdated
| class TestThread(threading.Thread): | ||
| def run(self): | ||
| with sync_playwright() as playwright: | ||
| browser = playwright.__dict__[browser_name].launch() |
There was a problem hiding this comment.
nit: getattr would be better since "dunder methods" should not be used. But since its only a test I'm fine with it.
There was a problem hiding this comment.
This is dead code, it should have been deleted.
pavelfeldman
force-pushed
the
m37threads
branch
from
a1b2b07 to
fc8f13e
Compare
mxschmitt
approved these changes
Dec 10, 2020
tests/sync/test_sync.py
Outdated
| @@ -15,6 +15,7 @@ | |||
| import os | |||
|
|
|||
| import pytest | |||
| import threading | |||
There was a problem hiding this comment.
Suggested change
| import threading |
pavelfeldman
force-pushed
the
m37threads
branch
2 times, most recently
from
ebfd78d to
501414b
Compare
pavelfeldman
force-pushed
the
m37threads
branch
from
501414b to
71d0d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.