Skip to content

chore: Update dependencies and configure Dependabot for monthly updates #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 10, 2020

Update dependencies and configure dependabot for monthly updates.

@mxschmitt
Copy link
Member

I wouldn't optimise the images, since the exact images get used in all the different language providers. For dependencies I think its preferred to update them manually every few months, since its only dev dependencies and does not harm anyone. Would also result in less noise in GitHub notifications for the maintainers.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Dec 10, 2020

I wouldn't optimise the images, since the exact images get used in all the different language providers. For dependencies I think its preferred to update them manually every few months, since its only dev dependencies and does not harm anyone. Would also result in less noise in GitHub notifications for the maintainers.

@mxschmitt optimize images means that the images are compressed and their dimensions are untouched

@mxschmitt
Copy link
Member

I wouldn't optimise the images, since the exact images get used in all the different language providers. For dependencies I think its preferred to update them manually every few months, since its only dev dependencies and does not harm anyone. Would also result in less noise in GitHub notifications for the maintainers.

@mxschmitt optimize images means that the images are compressed and their dimensions are untouched

It wouldn't bring any benefit in terms of performance or speed for new developers since we are using Git and the images are already in the tree like that. So the git clone would also take longer since new unknown binary files got added.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Dec 10, 2020

@mxschmitt Dependabot is now configured for monthly updates

@kumaraditya303 kumaraditya303 changed the title chore: Update dependencies and Optimize Images chore: Update dependencies and configure Dependabot for monthly updates Dec 10, 2020
@pavelfeldman
Copy link
Member

Does this fix any bugs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants