Skip to content

chore: Use bdist_wheel instead of custom script #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

chore: Use bdist_wheel instead of custom script #349

merged 1 commit into from
Dec 9, 2020

Conversation

kumaraditya303
Copy link
Contributor

@pavelfeldman @mxschmitt It is better and convectional to use bdist_wheel command to create wheel archives than to use a custom script which can be confusing for the users building from source.

With this change wheels can now be built using the convectional command bdist_wheel -

$ python setup.py bdist_wheel

@pavelfeldman pavelfeldman merged commit c606344 into microsoft:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @pavelfeldman