Skip to content

fix(stderr): remove the stderr patching hacks #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

fix(stderr): remove the stderr patching hacks #318

merged 1 commit into from
Nov 24, 2020

Conversation

pavelfeldman
Copy link
Member

@pavelfeldman pavelfeldman commented Nov 22, 2020 •
edited
Loading

A fix for #310

Will this make any bots fail? I am running it locally with -n 4 and things work, is that not xdist?

@mxschmitt
Copy link
Member

That #158 was the original bug report, did you use the -s option?

@pavelfeldman
Copy link
Member Author

did you use the -s option?

Yes, that's the only way to see the system err.

@mxschmitt
Copy link
Member

did you use the -s option?

Yes, that's the only way to see the system err.

Yeah thats the thing. If you are not using it, then pytest-xdist is monkey patching it (patching it during the runtime) and then the error occurs.

@pavelfeldman
Copy link
Member Author

@mxschmitt still not getting it...

I can run this:

DEBUG=pw:api pytest tests/sync -n 4

and it'll work, with no stderr in terminal

I can run this:

DEBUG=pw:api pytest tests/sync -n 4 -s

and it'll work, with stderr in terminal

Are there any steps to repro the actual issue?

mxschmitt
mxschmitt approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce it: create a test project, playwright + pytest-playwright, using the exact same pytest version and parameters as I did in the original bug-report.

Since I'm not able to reproduce, lets merge I would say and wait for real users who report it.

(This bug report was from an application from my previous company)

@pavelfeldman pavelfeldman merged commit ce9db80 into microsoft:master Nov 24, 2020
@mxschmitt mxschmitt mentioned this pull request Dec 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelfeldman @mxschmitt