Skip to content

fix: Use urllib instead of curl #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix: Use urllib instead of curl #302

merged 1 commit into from
Nov 17, 2020

Conversation

kumaraditya303
Copy link
Contributor

Fixes #301
Use urllib instead of curl for downloading zip files.

mxschmitt
mxschmitt approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@pavelfeldman pavelfeldman merged commit cb7abd5 into microsoft:master Nov 17, 2020
@pavelfeldman
Copy link
Member

pavelfeldman commented Nov 22, 2020 •
edited
Loading

I'll have to revert this, it looks like urllib has no notion of certificate validity. @kumaraditya303

pavelfeldman added a commit that referenced this pull request Nov 22, 2020
@pavelfeldman
Revert "fix: Use urllib instead of curl (#302)"
518cab8 
urllib does not know which certificates and good and which are bad.
@kumaraditya303
Copy link
Contributor Author

I'll have to revert this, it looks like urllib has no notion of certificate validity. @kumaraditya303

@pavelfeldman As per the python urllib documentation from python2.7 onwards For HTTPS URIs, urllib performs all the neccessary certificate and hostname checks by default. docs. Moreover urllib by default uses HTTP/1.1. docs
Did you face some difficulty using urllib for downloading zip files.

@pavelfeldman
Copy link
Member

Yeah, it did not recognize cdn certificate for me when running locally on my Mac. Not sure why.

@pavelfeldman
Copy link
Member

@kumaraditya303 plausible explanation: https://stackoverflow.com/questions/42098126/mac-osx-python-ssl-sslerror-ssl-certificate-verify-failed-certificate-verify

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Nov 22, 2020 via email

@pavelfeldman
Copy link
Member

I think it was 3.8 on my mac, don't remember how it was installed, definitely not from source. Are you saying this stack overflow response is not correct? It explains the behavior.

@kumaraditya303
Copy link
Contributor Author

There is a bug in python for mac where you have manually correct your ssl certificates in python, and I think that you are missing that step, use this command to fix it - open /Applications/Python\ 3.7/Install\ Certificates.command and replace 3.7 with your version. @pavelfeldman

@kumaraditya303 kumaraditya303 mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error running build_package.py
3 participants
@kumaraditya303 @pavelfeldman @mxschmitt