Skip to content

chore: Add py.typed #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

chore: Add py.typed #219

merged 1 commit into from
Oct 6, 2020

Conversation

bo5o
Copy link
Contributor

@bo5o bo5o commented Oct 4, 2020

This will allow type checkers to collect type information from this package.

See PEP 561.

@pavelfeldman
Copy link
Member

Does this also need a change to setup.py changes to include it in package_data?

@bo5o
chore: Add py.typed
86690ff 
This will allow type checkers to collect type information from this package.

See [PEP 561](https://www.python.org/dev/peps/pep-0561/).
@ghost
Copy link

ghost commented Oct 4, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@bo5o
Copy link
Contributor Author

bo5o commented Oct 4, 2020

I added an entry to MANIFEST.in.

According to the mypy documentation it is also necessary to set zip_safe=False, which might already be the default for this package (see setuptools documentation), so setting it explicitly is probably reasonable.

@pavelfeldman pavelfeldman merged commit b99dbf2 into microsoft:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bo5o @pavelfeldman