Skip to content

chore: bump greenlet to v2.0.2 #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2023
Merged

chore: bump greenlet to v2.0.2 #1917

merged 3 commits into from
May 15, 2023

Conversation

mxschmitt
Copy link
Member

Fixes #1915

@@ -1,5 +1,4 @@
python:
- 3.7
Copy link
Member Author

@mxschmitt mxschmitt May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

greenlet 2.0.2 fails to Install on Python 3.7 with:

Solving environment: ...working... failed
Traceback (most recent call last):
  File "/usr/share/miniconda/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda_build/cli/main_build.py", line 495, in main
    execute(sys.argv[1:])
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda_build/cli/main_build.py", line 475, in execute
    outputs = api.build(
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda_build/api.py", line 180, in build
    return build_tree(
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda_build/build.py", line 3078, in build_tree
    packages_from_this = build(metadata, stats,
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda_build/build.py", line 2115, in build
    create_build_envs(top_level_pkg, notest)
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda_build/build.py", line 1972, in create_build_envs
    environ.get_install_actions(m.config.test_prefix,
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda_build/environ.py", line 900, in get_install_actions
    actions = install_actions(prefix, index, specs, force=True)
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/common/io.py", line 84, in decorated
    return f(*args, **kwds)
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/plan.py", line 473, in install_actions
    txn = solver.solve_for_transaction(prune=prune, ignore_pinned=not pinned)
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/core/solve.py", line 134, in solve_for_transaction
    unlink_precs, link_precs = self.solve_for_diff(update_modifier, deps_modifier,
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/core/solve.py", line 177, in solve_for_diff
    final_precs = self.solve_final_state(update_modifier, deps_modifier, prune, ignore_pinned,
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/core/solve.py", line 295, in solve_final_state
    ssc = self._add_specs(ssc)
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/core/solve.py", line 702, in _add_specs
    conflicts = ssc.r.get_conflicting_specs(tuple(MatchSpec(_)
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/resolve.py", line 1110, in get_conflicting_specs
    C = r2.gen_clauses()
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/common/io.py", line 84, in decorated
    return f(*args, **kwds)
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/resolve.py", line 913, in gen_clauses
    for ms in self.ms_depends(prec):
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/resolve.py", line 795, in ms_depends
    deps = [MatchSpec(d) for d in prec.combined_depends]
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/models/records.py", line 342, in combined_depends
    result = {ms.name: ms for ms in MatchSpec.merge(self.depends)}
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/models/match_spec.py", line 478, in merge
    reduce(lambda x, y: x._merge(y, union), group) if len(group) > 1 else group[0]
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/models/match_spec.py", line 478, in <lambda>
    reduce(lambda x, y: x._merge(y, union), group) if len(group) > 1 else group[0]
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/models/match_spec.py", line 509, in _merge
    final = this_component.merge(that_component)
  File "/usr/share/miniconda/lib/python3.10/site-packages/conda/models/match_spec.py", line 785, in merge
    raise ValueError("Incompatible component merge:\n  - %r\n  - %r"
ValueError: Incompatible component merge:
  - '*mpich*'
  - 'mpi_mpich_*'

conda/conda#11442

Seems fine to remove Python 3.7 here since most of our users are on PIP anyways and we're gonna drop support for Python 3.7 next release.

@mxschmitt mxschmitt merged commit 04235c0 into main May 15, 2023
@mxschmitt mxschmitt deleted the bump-greenlet-2.0.2 branch May 15, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Remove overly strict dependency on old version of greenlet
2 participants