chore: roll Playwright to 1.19.0 #1157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
roll/1.19.0-beta-1644557062000
branch
from
9e9f13c to
bf0f2db
Compare
mxschmitt
commented
Feb 11, 2022
| params["headers"] = ( | ||
| params["headers"] if params.get("headers") else response.headers | ||
| ) | ||
| from playwright._impl._fetch import APIResponse |
There was a problem hiding this comment.
this prevents the circular dependency which would otherwise come up.
mxschmitt
commented
Feb 14, 2022
tests/server.py
Outdated
| @@ -101,7 +102,9 @@ def process(self) -> None: | |||
| path = uri.path | |||
|
|
|||
| if request_subscribers.get(path): | |||
| request_subscribers[path].set_result(request) | |||
| loop.call_soon_threadsafe( | |||
There was a problem hiding this comment.
TIL! we call it from another thread into the testing main thread. It was racing and test_frame_wait_for_nav_should_fail_when_frame_detaches was failing then.
mxschmitt
force-pushed
the
roll/1.19.0-beta-1644557062000
branch
from
4ab0145 to
53dd09d
Compare
mxschmitt
force-pushed
the
roll/1.19.0-beta-1644557062000
branch
from
53dd09d to
f1c082f
Compare
mxschmitt
force-pushed
the
roll/1.19.0-beta-1644557062000
branch
2 times, most recently
from
ec64ea6 to
aa0168a
Compare
mxschmitt
force-pushed
the
roll/1.19.0-beta-1644557062000
branch
from
aa0168a to
a41618f
Compare
mxschmitt
changed the title
pavelfeldman
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1120
Fixes #1134