Skip to content

feat: added web-first assertions #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Nov 17, 2021

Fixes #988

@kumaraditya303
Copy link
Contributor

It would be better to have expect(...).not.to_have_text rather than expect(...).not_to_have_text.

@mxschmitt
Copy link
Member Author

It would be better to have expect(...).not.to_have_text rather than expect(...).not_to_have_text.

Yes we also thought the same, but unfortunately not is a keyword in Python and thats why we can't use it as a method name. We thought about not_ instead but it felt wrong to us.

Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mxschmitt mxschmitt marked this pull request as ready for review November 19, 2021 18:06
@mxschmitt mxschmitt merged commit bea12da into microsoft:main Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Assertions for Python binding
3 participants