Skip to content

ports/webassembly/library: Make use of CustomEvent detail property. #9904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dlech
Copy link
Contributor

@dlech dlech commented Nov 9, 2022

This changes the CustomEvent for stdout to use the existing detail property of CustomEvent instead of adding a data property.

Followup to #9752 (comment)

cc @ntoll

This changes the CustomEvent for stdout to use the existing `detail`
property of CustomEvent instead of adding a `data` property.

Signed-off-by: David Lechner <david@pybricks.com>
@ntoll
Copy link
Contributor

ntoll commented Nov 10, 2022

LGTM 👍 (and thanks for fixing this, it was on my todo list)

@dlech
Copy link
Contributor Author

dlech commented Nov 10, 2022

no problem 😄

@dpgeorge
Copy link
Member

Merged in ea07ab0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants