You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original parsing would error out on any C declarations that are not typedefs
or extern variables. This limits what can go in mpconfig.h and mpconfigport.h,
as they are included in qstr.h. For instance even a function declaration would be
rejected and including system headers is a complete no-go.
That seems too limiting for a global config header, so makeqstrdata now
ignores everything that does not match a qstr definition.
The regex is set to match Q(.+) and just that on a line which I think should be strict enough.
The original parsing would error out on any C declarations that are not typedefs
or extern variables. This limits what can go in mpconfig.h and mpconfigport.h,
as they are included in qstr.h. For instance even a function declaration would be
rejected and including system headers is a complete no-go.
That seems too limiting for a global config header, so makeqstrdata now
ignores everything that does not match a qstr definition.
I'm am okay with this change, but have a few related comments:
It's actually qstrdefs.h that is parsed by this script (not qstr.h). And it really isn't a header file as such, since qstrdefs.h is never included in any C code (.c or .h file). Only the generated version (genhdr/qstrdefs.generated.h) is. But, I can't think of a better file extension, so probably just stick with what we already have.
mpconfig.h should not include any other headers except mpconfigport.h. And the latter should ideally not include system headers. I know that stmhal breaks this convention, but would be nice fix that.
But it is ok for mpconfigport.h to define functions (or include port specific headers defining functions), right?
Yes. It needs to declare types and functions for inclusion in the module list, etc. So in principal it's okay for it to include headers. But so far the unix/, windows/ and stmhal/ ports don't need to include anything in mpconfigport.h.
Well, @stinos smartly worked around need to #include something in windows/mpconfigport.h, but we apparently should just accept that it's better to let port's mpconfigport.h include whatever it wants, than add #ifdef's in py/*.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original parsing would error out on any C declarations that are not typedefs
or extern variables. This limits what can go in mpconfig.h and mpconfigport.h,
as they are included in qstr.h. For instance even a function declaration would be
rejected and including system headers is a complete no-go.
That seems too limiting for a global config header, so makeqstrdata now
ignores everything that does not match a qstr definition.
The regex is set to match Q(.+) and just that on a line which I think should be strict enough.