Skip to content

Support pgi as alternative gobject bindings. #9932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2017
Merged

Support pgi as alternative gobject bindings. #9932

merged 1 commit into from
Dec 13, 2017

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 5, 2017

PR Summary

xref #4810: allow using pgi instead of gi as bindings for gtk3.
The only reason to use pgi is really to allow testing on Travis (and similar contexts), hence the deliberate choice not to expose a rcParam.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswell tacaswell added this to the v2.2 milestone Dec 13, 2017
@tacaswell tacaswell merged commit 024d423 into matplotlib:master Dec 13, 2017
@anntzer anntzer deleted the pgi branch December 13, 2017 04:50
@anntzer anntzer mentioned this pull request Dec 13, 2017
Closed
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
GUI: gtk
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dopplershift @tacaswell @QuLogic