Skip to content

Minor cleanups for tests. #8846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2017
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 7, 2017

Remove an extraneous plt.show().

Make the triage_test window's minimal size smaller (so that it fits in
smaller screens).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Remove an extraneous plt.show().

Make the triage_test window's minimal size smaller (so that it fits in
smaller screens).
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jul 7, 2017
This allows one to copy-paste the test and use an interactive backend,
while maintaining the test result.  (Specifically, when using an
interactive backend, plt.draw will *not* set the renderer until
plt.show, whereas fig.canvas.draw will set it, allowing text extents to
be measured.)
@anntzer
Copy link
Contributor Author

anntzer commented Jul 8, 2017

Added an additional test cleanup: see commit message at ce85159.

@tacaswell tacaswell merged commit c4e6388 into matplotlib:master Jul 8, 2017
@anntzer anntzer deleted the test-cleanups branch July 8, 2017 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants