Skip to content

Revert #5392 #8452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2017
Merged

Revert #5392 #8452

merged 1 commit into from
Apr 12, 2017

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Apr 9, 2017

#5392 was introduced in an attempt to fix (slightly) arrows in polar plots, but it broke drawing arrows normally (see #8406).

This fixes #8406, which I think is more important than having polar arrows slightly fixed.

@dstansby dstansby added this to the 2.0.1 (next bug fix release) milestone Apr 9, 2017
@tacaswell
Copy link
Member

Can you add a test for this the (the example from #8406 is perfect, only need the png).

@anntzer
Copy link
Contributor

anntzer commented Apr 10, 2017

Perhaps the test of #8344 already checks that? @dstansby please confirm.

@dstansby
Copy link
Member Author

Yep, the change here affects the test added in #8344 , so this change would be caught there.

@anntzer
Copy link
Contributor

anntzer commented Apr 12, 2017

Given the recent extensive discussion regarding s-g, let's try to make this a bit more efficient (especially for PRs coming from core devs). (Obviously I have also authored not-so-clear PRs so it's also applies to myself).

The problem is that I have no idea what the -2/-1 in the diff means. Of course I could rummage through the arrow plotting code but do I really want to do that? I would be much happier approving/merging this if e.g. @dstansby could post two images, say before/after, and explain what the -2/-1 changes. It can be as simple as "using :-2 drops the point at coordinate x, y which makes the arrow wrong (fig 1); that was done to drop a point at coordinate x, y for the polar plot (fig 2)".

@tacaswell tacaswell merged commit 49adcaa into matplotlib:master Apr 12, 2017
@tacaswell
Copy link
Member

This commit was shared with #8344 which was backported to v2.0.x as 46247c7

@dstansby dstansby deleted the revert-5392 branch May 20, 2017 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FancyArrow, error in the polygon coordinates for shape 'full'
3 participants