Skip to content

BUG: fix image handling of over, under, and indexed color mapping #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

BUG: fix image handling of over, under, and indexed color mapping #6632

wants to merge 4 commits into from

Conversation

efiring
Copy link
Member

@efiring efiring commented Jun 23, 2016

This is a commit to handle indexed color mapping on top of @tacaswell's #6581 which fixes image rendering of over and under values.

tacaswell and others added 3 commits June 13, 2016 22:15
@tacaswell
FIX: carry through the over/under in resampling
c1ec9fa 
Use the same trick for carrying through the masked points to use the
green and blue channels to carry the under/over markers.
@efiring
Merge branch 'fix_over_under_images' of git://github.com/tacaswell/ma…
78a3ce7 
…tplotlib into tacaswell-fix_over_under_images
@efiring
When using indexed colormapping in image, map before resizing.
dcaf13a
@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Jun 23, 2016
@efiring
Copy link
Member Author

efiring commented Jun 23, 2016

I think the merge commit is superfluous; there is probably a simpler and cleaner way to do this, but I wanted to get the tests run so we can move forward if this combination of fixes doesn't break anything.

@tacaswell
Copy link
Member

Sorry I have been slow about this. I will (eventually) get your commit on
my branch.

On Thu, Jun 23, 2016 at 1:57 PM Eric Firing notifications@github.com
wrote:

I think the merge commit is superfluous; there is probably a simpler and
cleaner way to do this, but I wanted to get the tests run so we can move
forward if this combination of fixes doesn't break anything.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6632 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAMMhUcm6F6MiYh4lXf88Xyfa3K3qhVeks5qOsjsgaJpZM4I9EdO
.

@tacaswell
Copy link
Member

Closing as the commits from this have been added to the #6581

@tacaswell tacaswell closed this Jun 30, 2016
@efiring efiring deleted the tacaswell-fix_over_under_images branch October 24, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: duplicate
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@efiring @tacaswell @QuLogic