FIX: fix second error line drawing codepath #5401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `plot` knows how to dig into pandas Series to extract a label, make sure all internal calls to `plot` in `errorbar` pass `label='_nolegend_'`. Closes matplotlib#5393
|
You need to pop off the label from kwargs first in order to prevent duplicate kwarg entries. |
|
That is done way at the top, see https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/axes/_axes.py#L2789 The two major over-hauls that need to happen in errorbar are a) use z-order to specify above/below so we only have one code path there b) promote containers to full artists so that the |
|
Ah, ok. This makes sense to me as a good stop-gap solution. |
WeatherGod
added a commit
that referenced
this pull request
Nov 4, 2015
FIX: fix second error line drawing codepath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
plotknows how to dig into pandas Series to extracta label, make sure all internal calls to
plotinerrorbarpasslabel='_nolegend_'.Closes #5393
This is a minimal fix without tests, errorbar needs some more general attention.