Axes can't set navigate_mode. #30349
Merged
+11
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axes.set_navigate_mode is explicitly documented as private, and one should just defer to the associated toolbar in any case, which is actually handling the relevant event callbacks (calling only set_navigate_mode had no practical effect).
anntzer
force-pushed
the
no-axes-set_navigate_mode
branch
from
5b247e3 to
8355ee7
Compare
timhoffm
approved these changes
Jul 24, 2025
QuLogic
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axes.set_navigate_mode is explicitly documented as private, and one should just defer to the associated toolbar in any case, which is actually handling the relevant event callbacks (calling only set_navigate_mode had no practical effect).
PR summary
PR checklist