-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Correct typo of "buttons" to "button" in webagg backend #30337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
Is there any test that can be added in mpl (maybe a mock of some sort) for this? |
working on a minimal example to reproduce atm |
It is not a typo, both |
Still trying to wrap my head around a minimal working example, getting differing behaviour in a reduced case vs my application... But if button and buttons are both valid, and one works, any reason not to change it? |
They do different things. See #28453. |
Still working at an example, it's pretty finicky to reproduce so makes me wonder if there is something else going on under the hood, but forcing an error output in that block of code yields:
Which at least shows for some reason 'buttons' is not in the event. I'm happy to move this over to an issue for more discussion on ipympl or here, but I believe there is something still not right. |
There is something wrong in the sense that this is fixed in but some people using Personally I am not able to reproduce the problem. I use |
Minimal expample on my machine:
I'm looking to interactively view on vscode server, via remote ssh. I've blown away .vscode-server to ensure a clean environment server side, with a fresh venv of python 3.12.11 pip freeze yields:
Hope this might help? |
Full steps for me to reproduce reliably:
Returns:
|
Can you try using JupyterLab instead of VSCode? |
That doesn't throw any errors, so could be in the generation of the javascript sent to vscode? |
It seems likely that vscode is the key factor here, given my observation that I've never experienced a problem and I always use JupyterLab rather than vscode. I don't know what vscode does in these situations. My understanding is that it (and others such as PyCharm) reuse the Jupyter machinery but modify it for their own purposes. So it is quite possible that whatever they do has not been upgraded to work with ipympl 0.9.7 correctly. |
PR summary
cd37b73 introduces a typo which breaks visualisation in various interactive forms, mentioned in #29337, #29654
This is required for functionality of anything using interactive plots with the webagg backend
Discussion of this issue in other PR's/ issues imply upgrading ipympl to >0.9.5, this issue is persisting as I'm running matplotlib 3.10.3 and ipympl 0.9.7. Think this therefore needs to be fixed on matplotlibs side.
PR checklist