Skip to content

ENH: add back/forward buttons to osx backend move #29097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

tacaswell
Copy link
Member

PR summary

closes #29045

Adds bit mapping for forward and back buttons on mouse

@tacaswell tacaswell added this to the v3.10.0 milestone Nov 6, 2024
@QuLogic QuLogic requested a review from greglucas November 6, 2024 21:56
Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a mouse with back/forward buttons on it to test this with, but it seems reasonable. I also wasn't able to find any documentation to check against.

@greglucas greglucas merged commit 474b8c8 into matplotlib:main Nov 7, 2024
43 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 7, 2024
QuLogic added a commit that referenced this pull request Nov 7, 2024
…097-on-v3.10.x

Backport PR #29097 on branch v3.10.x (ENH: add back/forward buttons to osx backend move)
@tacaswell tacaswell deleted the enh/mac_more_mouse_buttons branch November 7, 2024 22:23
@tacaswell
Copy link
Member Author

I sorted out the right shifts by putting a NSLog in the code and printing out what the value was for each button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: implement back/forward buttons on mouse move events on macOS
3 participants