Attempt to produce an error message to indicate that there are less l… #24068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abels than legends
|
This is duplicate work in #24061 and #24063 to address #24050 . Please see the discussion in #24061 because I think there are some subtle questions here. I do not think that this PR is correct as-is as the check is on the auto-discovered handles + labels rather than the one the user passed to us. I am a bit distressed that the tests did not catch the failures I think this will cause. I am going to close this PR to keep all of the discussion in #24061 . Thank you for you work on this @carverde . Please join the existing discussion or pick another issue to work on. I hope we hear from you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…abels than legends