-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Change exception types, improve argument checking, and cleanups in mpl_toolkits #23550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00be652
to
a95cf32
Compare
a95cf32
to
3e8c347
Compare
anntzer
approved these changes
Aug 4, 2022
QuLogic
reviewed
Aug 4, 2022
@@ -48,6 +49,7 @@ def __init__(self, fig, pos, horizontal, vertical, | |||
self._horizontal = horizontal | |||
self._vertical = vertical | |||
self._anchor = anchor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can drop this line now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't some code quality tools complain if it is defined outside of __init__
? That was the reason anyway.
anntzer
reviewed
Aug 4, 2022
3e8c347
to
ad27ad7
Compare
ad27ad7
to
e94dfed
Compare
QuLogic
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Raise a more exact type.
Better argument checking.
Minor cleanups.
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).