Skip to content

Tweak Axes3D docstrings that refer to 2D plotting methods. #22394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2022
Merged

Tweak Axes3D docstrings that refer to 2D plotting methods. #22394

merged 1 commit into from
Feb 4, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 4, 2022

... and minor edits to 2D Axes.margins docs as well.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

timhoffm
timhoffm reviewed Feb 4, 2022
View reviewed changes
@anntzer
Tweak Axes3D docstrings that refer to 2D plotting methods.
3b3fb2a 
... and minor edits to 2D Axes.margins docs as well.
timhoffm
timhoffm approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May self-merge after CI pass (modulo permanent CI errors).

@anntzer
Copy link
Contributor Author

anntzer commented Feb 4, 2022

AFAICT, CI failure is spurious (forking on GHA, ps distiller=ghostscript on Azure).

@anntzer anntzer merged commit 789e855 into matplotlib:main Feb 4, 2022
@anntzer anntzer deleted the d branch February 4, 2022 23:04
@QuLogic QuLogic added this to the v3.6.0 milestone Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @QuLogic