-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: add support for imshow extent to have units #22230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
The *extent* of ``imshow`` can now be expressed with units | ||
---------------------------------------------------------- | ||
The *extent* parameter of `~.axes.Axes.imshow` and `~.AxesImage.set_extent` | ||
can now be expressed with units. | ||
|
||
.. plot:: | ||
:include-source: true | ||
|
||
import matplotlib.pyplot as plt | ||
import numpy as np | ||
from matplotlib.dates import HourLocator, DateFormatter | ||
from matplotlib.ticker import AutoMinorLocator | ||
|
||
fig, ax = plt.subplots() | ||
date_first = np.datetime64('2020-01-01', 'D') | ||
date_last = np.datetime64('2020-01-11', 'D') | ||
|
||
arr = [[i+j for i in range(10)] for j in range(10)] | ||
|
||
ax.imshow(arr, origin='lower', extent=[1, 11, date_first, date_last]) | ||
|
||
ax.yaxis.set_major_formatter(DateFormatter('%d/%m/%y:- %H00hours')) | ||
ax.yaxis.set_major_locator(HourLocator(byhour=[0, 6, 12, 18, 24])) | ||
ax.yaxis.set_minor_locator(AutoMinorLocator()) | ||
|
||
plt.show() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I
_process_unit_info
is very forgiving and is meant to be used in contexts where something else is going to make sure we do not have any extra kwargs. However in this case we are silently drop them on the floor (which in not great because now a typo will get silently ignored and not do what the wants....bugs where I am sure thatxnuints
is right but not doing what I want are among the most maddening!)Because the keywords used depends on the type of axes we are sitting on (😱 ) I think that this is the best option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made the changes
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checks have passed, could you please have a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any check for leftover
kwargs
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had added a check for the leftover kwargs. Could you please let me know what is supposed to be done when there are kwargs remaining? For eg, if we raise a ValueError as before, then other test cases break - like when
cmap
is used as a kwargThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to be more explicit about what gets passed to
set_extent
from__init__
, so that you can raise in the manner noted above.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. Does imshow even need to pass kwargs to set_extents? I have removed it. So that the user can pass those keyword arguments by calling set_extents and not in imshow. Does that sound correct?