Skip to content

Mention in a few more places that artists default to not-pickable. #19073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

Mention in a few more places that artists default to not-pickable. #19073

merged 1 commit into from
Dec 8, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 6, 2020

PR Summary

Closes #7238 (I can't think of other places where we could mention this...).

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

@QuLogic
Copy link
Member

QuLogic commented Dec 8, 2020

It could go in PickEvent's class description; that already says 'clicks close enough to an artist'.

@timhoffm timhoffm added this to the v3.4.0 milestone Dec 8, 2020
@timhoffm timhoffm merged commit 440af79 into matplotlib:master Dec 8, 2020
@anntzer anntzer deleted the notpickable branch December 8, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

better document how to configure artists for picking
3 participants
@anntzer @QuLogic @timhoffm