Skip to content

Add cheatsheet link to main doc page #18751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

timhoffm
Copy link
Member

PR Summary

Closes #18019.

Preview:
grafik

Draft:

  • The image has 1x resolution. Do we want to 2x oversample to have nicer images on retina? By that the file size would go up from 12kB to 33kB (could we serve different images depending on the screen scaling).
  • Do we want some text there? If so what?
  • Linking to the cheatsheet repo is probably not the best. - Create a subpage with all Cheat sheets in our docs and link there?

Feedback welcome.

@jklymak
Copy link
Member

jklymak commented Oct 16, 2020

Great. I'd serve the 2x version.

@story645
Copy link
Member

story645 commented Oct 16, 2020

I love it so so much, but I think we should link to the sheets in their repo since that's the most updated version. I don't think it needs text if it has altext explaining what it is but also kinda see the point of signposting since the image is tiny.

Maybe @rougier has a preference about where it should link to.

@jklymak
Copy link
Member

jklymak commented Oct 16, 2020

I think the idea was that the cheatsheets should be linked to versions and updated Matplotlib versions change....

@QuLogic
Copy link
Member

QuLogic commented Oct 16, 2020

* could we serve different images depending on the screen scaling).

This is done with srcset.

@timhoffm timhoffm marked this pull request as ready for review October 17, 2020 22:06
@QuLogic QuLogic requested a review from story645 October 19, 2020 22:01
@story645 story645 merged commit a32417f into matplotlib:master Oct 20, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 20, 2020
@timhoffm timhoffm deleted the cheatsheets branch October 20, 2020 20:57
QuLogic added a commit that referenced this pull request Oct 20, 2020
…751-on-v3.3.2-doc

Backport PR #18751 on branch v3.3.2-doc (Add cheatsheet link to main doc page)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cheatsheets to docs
4 participants