Skip to content

Always strip out date in postscript's test_savefig_to_stringio. #18420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 6, 2020

We already test that postscript output supports SOURCE_DATE_EPOCH in
test_determinism. Removing the date in test_savefig_to_stringio in all
cases makes it easier to reuse the test in mplcairo, as cairo does not
support SOURCE_DATE_EPOCH (or manually setting the date in postscript
output in any case); the test is not about SOURCE_DATE_EPOCH support
anyways.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

We already test that postscript output supports SOURCE_DATE_EPOCH in
test_determinism.  Removing the date in test_savefig_to_stringio in all
cases makes it easier to reuse the test in mplcairo, as cairo does not
support SOURCE_DATE_EPOCH (or manually setting the date in postscript
output in any case); the test is not about SOURCE_DATE_EPOCH support
anyways.
@jklymak jklymak merged commit df61699 into matplotlib:master Sep 8, 2020
@anntzer anntzer deleted the psundate branch September 8, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants