Skip to content

Deprecate NavigationToolbar2QT.parent. #16824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2020
Merged

Deprecate NavigationToolbar2QT.parent. #16824

merged 1 commit into from
Mar 18, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 18, 2020

This attribute shadows the normal Qt method parent() (which also returns
the parent window...), which is a source of confusion (https://gitter.im/matplotlib/matplotlib?at=5e7275164aec312c1f8f645d).

After the deprecation period passes, the parent property can be deleted and
parent() will simply be the method inherited from QToolBar.

Note that the attribute is not present on other backend toolbars either.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Deprecate NavigationToolbar2QT.parent.
52a204b 
This attribute shadows the normal Qt method parent() (which also returns
the parent window...), which is a source of confusion.  After the
deprecation period passes, the parent property can be deleted and
parent() will simply be the method inherited from QToolBar.

Note that the attribute is not present on other backend toolbars either.
@anntzer anntzer added this to the v3.3.0 milestone Mar 18, 2020
@timhoffm timhoffm merged commit bb7f9b9 into matplotlib:master Mar 18, 2020
@anntzer anntzer deleted the qtoolbarparent branch March 18, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: Qt
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @timhoffm