Cleanup axes_size. #15996
Merged
Cleanup axes_size. #15996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Dec 21, 2019
QuLogic
reviewed
Mar 8, 2020
|
|
||
| return rel_size, abs_size | ||
| def __init__(self, artist_list): | ||
| super().__init__(artist_list, "width") | ||
|
|
||
|
|
||
| class MaxHeight(_Base): |
There was a problem hiding this comment.
I think this should be:
Suggested change
| class MaxHeight(_Base): | |
| class MaxHeight(MaxExtent): |
Rewrite MaxWidth, MaxHeight to reuse the MaxExtent logic; fix MaxExtent to work even if artist_list is empty. Docstrings cleanups. Move some typechecks (`float(...)` -> check_isinstance) to the class constructors (so that all calls benefit from it).
|
indeed, fixed and rebased. |
QuLogic
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite MaxWidth, MaxHeight to reuse the MaxExtent logic.
Docstrings cleanups.
Move some typechecks (
float(...)-> check_isinstance) to the classconstructors (so that all calls benefit from it).
PR Summary
PR Checklist