Skip to content

Small animation cleanup. #15740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2019
Merged

Small animation cleanup. #15740

merged 1 commit into from
Nov 22, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 21, 2019

Animation.extra_args is always a list (we normalize None to be the rc in
the constructor) so we don't need to separately handle the empty case.

Noticed while reviewing #15739.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Small animation cleanup.
d82dd36 
Animation.extra_args is always a list (we normalize None to be the rc in
the constructor) so we don't need to separately handle the empty case.
story645
story645 approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be switched to f'strings in a follow up PR?

@anntzer
Copy link
Contributor Author

anntzer commented Nov 22, 2019

I think I already have enough "maintenance" PRs like this ;)

@story645 story645 merged commit 907efd0 into matplotlib:master Nov 22, 2019
@QuLogic QuLogic added this to the v3.3.0 milestone Nov 22, 2019
@anntzer anntzer deleted the extra_args branch November 22, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@story645 story645 story645 approved these changes

Assignees
No one assigned
Labels
Maintenance topic: animation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @dopplershift @story645 @QuLogic