Use faulthandler in CI. #10291
Closed
Use faulthandler in CI. #10291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
added
the
Release critical
|
3.4 isn't passing. I thought I restarted yesterday, but maybe not. |
|
Nope, 3.4 still not passing 👎 |
|
Wait, we are already using pytest-faulthandler (https://github.com/matplotlib/matplotlib/blob/master/.travis.yml#L169) which is autoactivated anyways.. |
tacaswell
removed
the
Release critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Mostly closes #10216. Also restores the test of running under python -OO (via PYTHONOPTIMIZE, which has the same effect) which had been accidentally removed in #10217.
PR Checklist