kill transitional msWindow #939
Conversation
|
Not correctly working. (Please don't care about the black glitches on the recordings, it does that on screen recordings only). When starting LibreOffice by itself, it displays correctly BUT there is a window resize problem, and/or a focus problem (could not get that on video). See https://user-images.githubusercontent.com/1292007/210753981-0693d923-0358-4ca9-8174-82444eb74c04.mp4 When clicking on a file in Nautilus, it does not work fix anyting. See https://user-images.githubusercontent.com/1292007/210754417-e77f65e0-8fe4-4a01-936f-8d53319ed424.mp4 |
|
The first issue is fixed by another PR #936 |
PapyElGringo
force-pushed
the
fix-855-929
branch
from
ae0248b to
c3bf0e5
Compare
|
@tiramiseb can you give another try? |
Co-authored-by: Aron Granberg <HalfVoxel@users.noreply.github.com>
Co-authored-by: Aron Granberg <HalfVoxel@users.noreply.github.com>
Co-authored-by: Aron Granberg <HalfVoxel@users.noreply.github.com>
Co-authored-by: Aron Granberg <HalfVoxel@users.noreply.github.com>
Co-authored-by: Aron Granberg <HalfVoxel@users.noreply.github.com>
Co-authored-by: Aron Granberg <HalfVoxel@users.noreply.github.com>
Co-authored-by: Aron Granberg <HalfVoxel@users.noreply.github.com>
Co-authored-by: Aron Granberg <HalfVoxel@users.noreply.github.com>
|
Just tested now on ea0627a. It's better, but not quite there yet. Sometimes it is okayish (not as smooth as I would expect: the first time I move the mouse, the focus follows, but not the window opacity). https://user-images.githubusercontent.com/1292007/210949112-7c5fa9b0-905e-4d6b-9a6b-949001ae534d.mp4 Sometimes it looks okayish (same window opacity problem) but the LibreOffice window does not receive click events. https://user-images.githubusercontent.com/1292007/210949267-079415e7-a0bb-4d6b-af20-3d5ff58559fa.mp4 Sometimes the temporary window appears in a flash, then:
See https://user-images.githubusercontent.com/1292007/210949632-db52000f-2bae-4b79-bbc2-6c6bb20cc2df.mp4 Moreover, in that third situation, when restarting GNOME Shell (Alt-F2 + r), the space that was reserved and filled with dark gray is now reserved with the usual icon and "Click anywhere to launch" stuff. |
src/layout/msWorkspace/msWindow.ts
Outdated
| @@ -373,8 +371,8 @@ export class MsWindow extends Clutter.Actor { | |||
| ); | |||
| this.trackAppChanges(); | |||
| state.matchingInfo.appId = this.app.id; | |||
| this.placeholder = this.buildPlaceHolder(); | |||
| this.msContent.placeholder = this.placeholder; | |||
| this.placeholder.setIcon(this.app.create_icon_texture(248)); | |||
There was a problem hiding this comment.
You are using this constant in two places. Extract to global named constant.
There was a problem hiding this comment.
done I hope the name isn't so bad this time !
| @@ -29,6 +29,8 @@ import { PrimaryBorderEffect } from './tilingLayouts/baseResizeableTiling'; | |||
|
|
|||
| const isWayland = GLib.getenv('XDG_SESSION_TYPE').toLowerCase() === 'wayland'; | |||
|
|
|||
| const PLACEHOLDER_ICON_SIZE = 248; | |||
There was a problem hiding this comment.
Very reasonable. If I'd suggest anything it would be PLACEHOLDER_APP_ICON_SIZE, but that's nitpicking.
|
@tiramiseb I fixed one of the issues you mentioned that was related to this PR. But the focus issue is not specific to this one. |
|
I tried it in order to check if it fixes #855 but encountered issues when directly exporting a PDF using the toolbar. The window went grey and was unresponsive. After a libreoffice restart the recovery window was not anywhere in the window list until I restarted material-shell. After that the PDF export worked again. |
No description provided.