Skip to content

fix incompatibility with Gnome 40 & 41 #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix incompatibility with Gnome 40 & 41 #937

merged 2 commits into from
Jan 4, 2023

Conversation

PapyElGringo
Copy link
Collaborator

@PapyElGringo PapyElGringo commented Jan 3, 2023 •
edited
Loading

Need to be tested

@PapyElGringo PapyElGringo requested a review from HalfVoxel January 3, 2023 10:49
@PapyElGringo PapyElGringo changed the title fix incompatibility fix incompatibility with Gnome 40 & 41 Jan 3, 2023
HalfVoxel
HalfVoxel requested changes Jan 3, 2023
View reviewed changes
src/widget/material/button.ts Outdated
};
event: Clutter.Event | undefined;
constructor() {
super();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructor override?

@PapyElGringo PapyElGringo merged commit e7ca507 into main Jan 4, 2023
@PapyElGringo PapyElGringo deleted the fix_incompatibility_click branch January 4, 2023 11:19
@PapyElGringo PapyElGringo mentioned this pull request Jan 6, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalfVoxel HalfVoxel HalfVoxel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PapyElGringo @HalfVoxel