Implement a recent search provider for the sidebar search. #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the providers have previously been ordered sequentially, you often have to either use the mouse or press 'down' many times to get to the item that you want, even if you open the exact same app every time. This commit records the history of which things you actually open and suggests those when relevant. It will only suggest a single item at a time and uses various pieces of information such as what the user is searching for, what applications are open, the current time of day, and a few more. If it cannot decide between several items in the history, then nothing will be shown. Most likely a suggestion will show up if the user types a few more characters.
|
@PapyElGringo did you check this out? |
PapyElGringo
requested changes
Feb 16, 2023
There was a problem hiding this comment.
I only have a small code review request.
I'm a bit concerned about the complexity added for this feature and the changes in result predictability.
But since it's also could be a killer feature for some I'll allow the merge but in the eventuality we get mixed feedback we should be prepared to add an option toggle in the settings to disable the feature.
| history: HistoryItem[] = []; | ||
|
|
||
| get title(): string { | ||
| return 'Recent'; |
There was a problem hiding this comment.
If we want internationalization we can use https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/43.3/po/en_GB.po#L4054 but it's in uppercase...
There was a problem hiding this comment.
Hmm. Would be nice. But sadly wouldn't work with the casing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the providers have previously been ordered sequentially, you often
have to either use the mouse or press 'down' many times to get to the item that you want,
even if you open the exact same app every time.
This commit records the history of which things you actually open and suggests those when relevant.
It will only suggest a single item at a time and uses various pieces of information such as what the user is searching for, what applications are open, the current time of day, and a few more.
If it cannot decide between several items in the history, then nothing will be shown. Most likely a suggestion will show up if the user types a few more characters.
