Convert ElasticSearchEngine->performSearch result to array when the…
#251
Conversation
…re is callback passed (so it's the same when no callback is passed)
| @@ -197,7 +197,7 @@ private function performSearch(BaseBuilder $builder, $options = []) | |||
| $callback, | |||
| $this->elasticsearch, | |||
| $searchBody | |||
| ); | |||
| )->asArray(); | |||
There was a problem hiding this comment.
I think same approach before but how could we be sure this callback return an object and it has asArray method?
There was a problem hiding this comment.
So does that mean that omitting asArray call was intentional? As in it is left up to the callback to decide what is returned?
There was a problem hiding this comment.
And actually now that I think, its a callback. There's literally no way to make sure that it will return what you expect, cause ultimately the developer really can return whatever they want, and I am not aware of any way in php to enforce a return value of callback.
So I think maybe the only thing i can do, is add the appropriate type hint via annotation there?
There was a problem hiding this comment.
Yes, while implementing upgrade I faced same problem and could not find a proper solution and I keep it as is without asArray(). What it can be, we may use invoke method of a class instead of callback. The user can implement a callback with class. The invoke could have return type.
|
fixes #250
…re is callback passed (so it's the same when no callback is passed)
I have tried to set up the docker image with
make installas per CONTRIBUTING.md, but I got some error about not supported architecture (I'm on M2 processor). If not too much trouble, could I ask you to perform the tests?Either-way I have manually tested this update on my local app, and it works as I think it should be, so unless this breaks something else, everything should be ok.