Skip to content

Bump lodash-es to v4.17.20. #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump lodash-es to v4.17.20. #4972

wants to merge 1 commit into from

Conversation

opichals
Copy link

@opichals opichals commented Nov 5, 2020 •
edited
Loading

Steps to reproduce

  • Update the lodash version in lodash-cli tool 
    cd ../lodash-cli
vi package.json
npm install
cd -
  • Run the lodash-cli tool with the proper exports flag 
    node ../lodash-cli/bin/lodash modularize exports="es" -o ./

After merging this should be hopefully ready for npm publish in the es branch and tagged 4.17.20-es.

@jsf-clabot
Copy link

jsf-clabot commented Nov 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nerdkid93
Copy link

nerdkid93 commented Nov 5, 2020 •
edited
Loading

This is a near duplicate of #4947, but I pulled your README.md changes into that existing PR, since I had forgotten to update that

@opichals
Copy link
Author

opichals commented Nov 5, 2020

@nerdkid93 Ah, sorry, just noticed. I created it based on this https://github.com/lodash/lodash/issues/4879#issuecomment-722563017 made by the npmjs.org registry collaborator...

@opichals
Copy link
Author

opichals commented Nov 5, 2020

Related lodash-archive/lodash-cli#143

@opichals
Copy link
Author

@bnjmnt4n Since it looks like you did the npm publish for lodash@4.17.20. Could you have a look at this?

@bnjmnt4n
Copy link
Contributor

Thanks for the PR! I had to re-generate the build myself, but really appreciate your help here. Closing!

@bnjmnt4n bnjmnt4n closed this Dec 20, 2020
@jdalton jdalton added the issue bankruptcy Closing the issue/PR to start fresh label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate issue bankruptcy Closing the issue/PR to start fresh
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@opichals @jsf-clabot @nerdkid93 @bnjmnt4n @jdalton