Skip to content

Extract container logs on bootstrap test failure #9769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Extract container logs on bootstrap test failure #9769

wants to merge 1 commit into from

Conversation

dominikschubert
Copy link
Member

Motivation

Hunting failings tests here is quite awful because the CI doesn't actually show you what went wrong in the started container.

Changes

  • If the container can't start, at least print the logs so that we see them in CI. Also locally this is quite helpful since the container is by default immediately removed.

TODO

Might want to go through the rest of the bootstrap tests and do similar things there

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

       2 files         2 suites   1h 7m 18s ⏱️
2 372 tests 2 058 ✔️ 314 💤 0 ❌
2 373 runs  2 058 ✔️ 315 💤 0 ❌

Results for commit 186ffa49.

@simonrw simonrw added this to the Playground milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw Awaiting requested review from simonrw simonrw will be requested when the pull request is marked ready for review simonrw is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikschubert @simonrw