rework eventbus scheduled rule execution #9298
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrau
force-pushed
the
rework-job-scheduler
branch
from
c263b64 to
f1d2eca
Compare
thrau
force-pushed
the
rework-job-scheduler
branch
2 times, most recently
from
0cc7a77 to
29f9405
Compare
thrau
force-pushed
the
rework-job-scheduler
branch
from
29f9405 to
c62a127
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The key mechanism of the
JobSchedulerclass was a 59.9 second wait event in a while true loop:localstack/localstack/services/events/scheduler.py
Lines 71 to 73 in c7b8b95
We have an event-based scheduler utility that could be used for the JobScheduler, which will also make things easier for our time simulation project.
So this PR is both about cleaning up tech debt and making the JobScheduler more flexible.
Changes